Remove dead goto-def/peek/ctrl-click EA impls for TS. TS is now entirely on LSP for these experiences. #71098
Conversation
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
|
@MariaSolOs FYI. |
CyrusNajmabadi
changed the title
| var service = document.GetRequiredLanguageService<INavigableItemsService>(); | ||
| var service = document.GetLanguageService<INavigableItemsService>(); | ||
| if (service is null) | ||
| return ImmutableArray<OmniSharpNavigableItem>.Empty; |
There was a problem hiding this comment.
just being paranoid. this is omnisharp. so presumably only for C#/VB. But i'm not taking chances.
There was a problem hiding this comment.
Note even VB, just C#. But I'm ok with paranoia.
| var service = document.GetRequiredLanguageService<INavigableItemsService>(); | ||
| var service = document.GetLanguageService<INavigableItemsService>(); | ||
| if (service is null) | ||
| return null; |
There was a problem hiding this comment.
This is paranoid as our LSP server is only for languages that support this. But this just means we're not dependong that. And, for example, if xaml didn't support this, we'd be ok.
There was a problem hiding this comment.
I kind of prefer throwing actually. It isn't expected that we would generally hit this, and if we do we'll get errors that tell us what is going wrong. It won't take down the LSP server or anything.
| var service = document.GetRequiredLanguageService<INavigableItemsService>(); | ||
| var service = document.GetLanguageService<INavigableItemsService>(); | ||
| if (service is null) | ||
| return null; |
There was a problem hiding this comment.
I kind of prefer throwing actually. It isn't expected that we would generally hit this, and if we do we'll get errors that tell us what is going wrong. It won't take down the LSP server or anything.
ghost
added this to the 
If https://devdiv.visualstudio.com/DevDiv/_git/TypeScript-VS/pullrequest/514833 goes in first, we can remove more here.